ci(deploy): update deployment script to use artifacts #371
+59
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
reviewed
Oct 3, 2024
mraszyk
reviewed
Oct 3, 2024
mraszyk
reviewed
Oct 3, 2024
|
|
||
| BUILD_MODE=$network dfx deploy --network $network app_wallet --with-cycles 2000000000000 $([[ -n "$subnet_type" ]] && echo "--subnet-type $subnet_type") | ||
| else | ||
| echo "Deploying the app_wallet canister to the '$network' network is not yet supported automatically." |
There was a problem hiding this comment.
Because dfx is not exposing the —no-delete option of icx-asset
mraszyk
reviewed
Oct 3, 2024
| echo "Deploying the app_wallet canister to the '$network' network is not yet supported automatically." | ||
| echo | ||
| echo "Please deploy the app_wallet canister manually using the following command:" | ||
| echo "icx-asset --pem YOUR_IDENTITY_PEM_PATH --replica TARGET_REPLICA_HTTP sync --no-delete $canister_id_output artifacts/wallet-dapp/dist" |
There was a problem hiding this comment.
Can't we just run this here instead of failing? If we do want to fail, maybe exit 1 would be appropriate here?
There was a problem hiding this comment.
Actually I think we could require the identity pem path as an argument and that would enable us to run the command instead of just logging it, I’ll try that.
Co-authored-by: mraszyk <[email protected]>
Co-authored-by: mraszyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.