feat(control-panel): support deploying large station WASM #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keplervital
reviewed
Oct 3, 2024
| // The canister modules required for the control panel. | ||
| type UploadCanisterModulesInput = record { | ||
| // The upgrader wasm module to use for the station canister. | ||
| upgrader_wasm_module : opt blob; | ||
| // The station wasm module to use. | ||
| station_wasm_module : opt blob; | ||
| // Optional extra chunks of the station canister wasm module. | ||
| station_wasm_module_extra_chunks : opt opt WasmModuleExtraChunks; |
There was a problem hiding this comment.
maybe i've already asked before, but why the opt opt here?
There was a problem hiding this comment.
I know it's confusing...
The outer opt stands for "do I want to override this field or not". The inner opt stands for "is this WASM chunked or not".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for deploying large station WASM into the control panel canister.