Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): expose backend allow_signing function #2634

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat(frontend): expose backend allow_signing function #2634

merged 3 commits into from
Oct 3, 2024
+50 −0

Conversation

peterpeterparker
Copy link
Member

Motivation

We need to expose the new allow_signing function at the API level for #2632.

Changes

  • Adding allowSigning to backend canister and API

@peterpeterparker peterpeterparker requested a review from a team as a code owner October 3, 2024 13:58
@DenysKarmazynDFINITY
Copy link
Contributor

Gonna come back after the PR is updated with the code from main 🙂

@peterpeterparker
Copy link
Member Author

@DenysKarmazynDFINITY updated. go.

DenysKarmazynDFINITY
DenysKarmazynDFINITY approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@DenysKarmazynDFINITY DenysKarmazynDFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@peterpeterparker peterpeterparker merged commit 0425e1f into main Oct 3, 2024
10 checks passed
@peterpeterparker peterpeterparker deleted the feat/expose-allown-signing branch October 3, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysKarmazynDFINITY DenysKarmazynDFINITY DenysKarmazynDFINITY approved these changes

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY Awaiting requested review from AntonioVentilii-DFINITY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @DenysKarmazynDFINITY