Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade drun #4678

Merged
merged 3 commits into from
Sep 9, 2024
Merged

chore: Upgrade drun #4678

merged 3 commits into from
Sep 9, 2024

Conversation

luc-blaeser
Copy link
Contributor

@luc-blaeser luc-blaeser commented Aug 29, 2024 •
edited
Loading

Using IC 2024-08-16 with some adjustments:

@luc-blaeser luc-blaeser self-assigned this Aug 29, 2024
@luc-blaeser luc-blaeser added the dependencies Pull requests that update a dependency file label Aug 29, 2024
@luc-blaeser luc-blaeser mentioned this pull request Aug 29, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Comparing from adb31da to 7a93388:
The produced WebAssembly code seems to be completely unchanged.

@luc-blaeser luc-blaeser marked this pull request as ready for review August 29, 2024 11:14
@luc-blaeser luc-blaeser mentioned this pull request Aug 30, 2024
Open
ggreif
ggreif approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luc-blaeser
Copy link
Contributor Author

Thank you, Gabor!

@luc-blaeser luc-blaeser added the automerge-squash When ready, merge (using squash) label Sep 9, 2024
@mergify mergify bot merged commit 32a7bb1 into master Sep 9, 2024
10 checks passed
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Sep 9, 2024
@crusso
Copy link
Contributor

crusso commented Sep 10, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif approved these changes

@crusso crusso Awaiting requested review from crusso

Assignees

@luc-blaeser luc-blaeser

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luc-blaeser @crusso @ggreif