-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EOP: Rust Upgrade for RTS #4648
Closed
luc-blaeser
wants to merge
57
commits into
luc/integrate-enhanced-orthogonal-persistence
from
luc/rts-rust-upgrade
Closed
EOP: Rust Upgrade for RTS #4648
luc-blaeser
wants to merge
57
commits into
luc/integrate-enhanced-orthogonal-persistence
from
luc/rts-rust-upgrade
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>
luc-blaeser
commented
Aug 16, 2024
Base automatically changed from
luc/latest-integrated-eop
to
luc/integrate-enhanced-orthogonal-persistence
August 20, 2024 13:57
Base automatically changed from
luc/integrate-enhanced-orthogonal-persistence
to
luc/graph-copy-on-stable-heap64
August 26, 2024 14:20
Base automatically changed from
luc/graph-copy-on-stable-heap64
to
luc/stable-heap64
August 26, 2024 14:20
luc-blaeser
changed the base branch from
master
to
luc/integrate-enhanced-orthogonal-persistence
August 29, 2024 07:30
Closing in favor of #4677 to merge with latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading integrated EOP (#4488) to recent Rust and LLVM dependencies:
Special aspects:
wasm32
andwasm64
.dylink.0
instead ofdylink
.GOT.mem
for RTS in the Motoko linker.wasm-ld
) needs a bug fix: [lld][WebAssembly] Fix relocation of Wasm table index with GOT access llvm/llvm-project#104043. Therefore, patchingwasm-ld
.NaN
andinfinity
. Moreover, one particular output format (hexadecimal float) is no longer supported. Updating the documentation and base library is needed.musl
is still used in 32-bit but not in 64-bit. In the future, we should get rid ofmusl
entirely. Themusl
import is rather old, upgrading is complicated as it involves a lot of unwanted dependencies.emscripten
for 64-bit Wasm compilation (as there is a nix build issue with latestemscripten
). Instead, theclang
compiler is directly invoked.Note:
nix-shell
crashes with a segmentation fault with this PR, you need to upgradenix
. For this, you need to manually uninstall and re-installnix
.