Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Motoko footer image #4640

Merged
merged 5 commits into from
Jul 31, 2024
Merged

docs: Add Motoko footer image #4640

merged 5 commits into from
Jul 31, 2024

Conversation

jessiemongeon1
Copy link
Contributor

@jessiemongeon1 jessiemongeon1 commented Jul 30, 2024 •
edited
Loading

Adds a footer image to all Motoko docs (aside from Base reference pages)

Screenshot 2024-07-30 at 3 48 11 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Comparing from 4a3ff85 to 77abe3e:
The produced WebAssembly code seems to be completely unchanged.

ggreif
ggreif approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We should not fall in the trap of making technical content too flashy.

@jessiemongeon1 jessiemongeon1 merged commit 9badafc into master Jul 31, 2024
8 checks passed
@ggreif ggreif deleted the add-motoko-ghost branch July 31, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessiemongeon1 @ggreif