Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mo-doc): include public variables in generated docs #4626

Merged
merged 4 commits into from
Jul 25, 2024
Merged

fix(mo-doc): include public variables in generated docs #4626

merged 4 commits into from
Jul 25, 2024

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Jul 23, 2024

Resolves #4579.

@rvanasa rvanasa added the tools Motoko-related tooling label Jul 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Comparing from 132b4b4 to 6a2091e:
The produced WebAssembly code seems to be completely unchanged.

@rvanasa rvanasa marked this pull request as ready for review July 23, 2024 20:12
crusso
crusso approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@rvanasa rvanasa merged commit 4796965 into master Jul 25, 2024
8 checks passed
@rvanasa rvanasa deleted the issue-4579 branch July 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

@dfx-json dfx-json dfx-json approved these changes

Assignees
No one assigned
Labels
tools Motoko-related tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug when mo-doc generating docs for public var.
3 participants
@rvanasa @crusso @dfx-json