Add support for alternative origins to VC issuer #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having alternative_origins support allows to simplify the VC e2e tests. This will be done in follow-up PRs.
frederikrothenberger
force-pushed
the
frederik/vc-issuer-alterantive-origins
branch
from
9f32056
to
006cdd0
Compare
lmuntaner
approved these changes
Jul 4, 2024
| @@ -451,6 +451,21 @@ fn static_headers() -> Vec<HeaderField> { | |||
| vec![("Access-Control-Allow-Origin".to_string(), "*".to_string())] | |||
| } | |||
|
|
|||
| #[update] | |||
| fn set_alternative_origins(alternative_origins: String) { | |||
There was a problem hiding this comment.
Wouldn't it be easier to use if it expected a list of origins and the format is managed internally?
There was a problem hiding this comment.
I think it is useful to be able to configure and test invalid values too.
There was a problem hiding this comment.
ah, true, that's a good point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having alternative_origins support allows to simplify the VC e2e tests. This will be done in follow-up PRs.
🟡 Some screens were changed