Add support to reconfigure derivation_origin for VC issuer #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows to reconfigure the expected frontend hostname as well as the derivation origin. This will be used in the future to simplify the e2e tests. Since this is most useful in e2e tests if the configuration is _not_ guarded by the controller, the guard is removed for the `configure` method too for consistency.
| config: &IssuerInit, | ||
| ) -> Result<(), CallError> { | ||
| call_candid_as(env, canister_id, sender, "configure", (config,)) | ||
| call_candid(env, canister_id, "configure", (config,)) |
There was a problem hiding this comment.
I removed the need to specify the sender as these methods can now be called anonymously again.
lmuntaner
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to reconfigure the expected frontend hostname as well as the derivation origin. This will be used in the future to simplify the e2e tests.
Since this is most useful in e2e tests if the configuration is not guarded by the controller, the guard is removed for the
configuremethod too for consistency.