Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI fixes landing page #2527

Merged
merged 4 commits into from
Jul 9, 2024
Merged

UI fixes landing page #2527

merged 4 commits into from
Jul 9, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Jul 4, 2024 •
edited by github-actions bot
Loading

Main motivation is to fix a few UI changes requested by design:

  • Change title styles for the marketing copy in the landing page.
  • Add more space between footer links and change the hover color in the landing page.
  • Improve the responsiveness by setting the breakpoint at 1024 and setting a max width in the content.
  • Change the vertical padding for the right pane on mobile.
🟡 Some screens were changed

@lmuntaner
Copy link
Collaborator Author

lmuntaner commented Jul 4, 2024 •
edited
Loading

New UI:

At 1024px:
Screenshot 2024-07-04 at 11 19 49

Large Desktop:
Screenshot 2024-07-04 at 11 20 00

Mobile:
Screenshot 2024-07-04 at 11 20 14

@lmuntaner lmuntaner marked this pull request as ready for review July 4, 2024 12:42
@lmuntaner lmuntaner requested a review from a team as a code owner July 4, 2024 12:42
@lmuntaner
Copy link
Collaborator Author

@frederikrothenberger PR approved by Artem and ready for review

@lmuntaner
Copy link
Collaborator Author

@meodai could you take a look?

meodai
meodai reviewed Jul 8, 2024
View reviewed changes
src/frontend/src/styles/main.css Outdated Show resolved Hide resolved
src/frontend/src/styles/main.css Show resolved Hide resolved
src/frontend/src/styles/main.css Outdated Show resolved Hide resolved
@lmuntaner lmuntaner requested a review from meodai July 9, 2024 06:44
@lmuntaner
Copy link
Collaborator Author

@meodai ready for another review! Thanks!

@lmuntaner lmuntaner added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 3f74a48 Jul 9, 2024
65 checks passed
@lmuntaner lmuntaner deleted the lm-ui-fixes-landing-page branch July 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meodai meodai meodai approved these changes

@frederikrothenberger frederikrothenberger Awaiting requested review from frederikrothenberger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @meodai