Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for number of successful prepare_id_alias calls #2519

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Jun 26, 2024

This PR adds a metric for how many prepare_id_alias calls have been handled. This number can be used to infer the number of VCs presented using Internet Identity.


🟡 Some screens were changed

This PR adds a metric for how many prepare_id_alias calls have been
handled. This number can be used to infer the number of VCs presented
using Internet Identity.
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ideally could we also store the app where it's coming from like we do for logins?

Even more ideally, two new metrics per dapps, one per relying party and one per issuer.

But definitely not in this PR.

@frederikrothenberger
Copy link
Member Author

LGTM!

Ideally could we also store the app where it's coming from like we do for logins?

Even more ideally, two new metrics per dapps, one per relying party and one per issuer.

But definitely not in this PR.

Yes, that would be interesting. Agreed! However, we should be careful about more targeted stats, as long as the volume of VC flows is low (i.e. to not leak information about the context).

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 3f049ec Jun 26, 2024
65 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/vc-counter branch June 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants