Increase stack size to 3MB #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR increases the stack size from the 1MB default to 3MB as per recommendation [here](https://dfinity.slack.com/archives/CH4CADCJX/p1717748706241909?thread_ts=1716464873.584739&cid=CH4CADCJX). I did some tests with very small stack sizes to see when we hit errors to get a feeling for the current stack usage of II. The tests indicate that we currently use more than 48KB but fewer than 200KB of stack. Since we are also very lean on heap usage (~6.5 MB currently) we can afford to increase the stack size to have more leeway with regards to the stack.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the stack size from the 1MB default to 3MB as per recommendation here.
I did some tests with very small stack sizes to see when we hit errors to get a feeling for the current stack usage of II. The tests indicate that we currently use more than 48KB but fewer than 200KB of stack.
Since we are also very lean on heap usage (~6.5 MB currently) we can afford to increase the stack size to have more leeway with regards to the stack.
🟡 Some screens were changed