Skip to content

Commit

Permalink
Remove breaking change exception of previous release (#2510)
Browse files Browse the repository at this point in the history
Removes the breaking change exception of the previous release as
it is no longer needen.
  • Loading branch information
frederikrothenberger authored Jun 17, 2024
1 parent d06a6c9 commit 0558bdf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 31 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/canister-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -967,22 +967,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-didc
- name: 'Get latest release'
uses: actions/github-script@v7
id: latest-release-tag
with:
result-encoding: string
script: return (await github.rest.repos.getLatestRelease({owner:"dfinity", repo:"internet-identity"})).data.tag_name;
- name: "Check canister interface compatibility"
run: |
release="release-2024-05-13"
# undo the breaking changes that we _explicitly_ made
# remove after the next release
# if we accidentally introduced other breaking changes, the patch would no longer apply / fix them
# making this job fail.
if [ "${{ steps.latest-release-tag.outputs.result }}" == "$release" ]; then
echo "Rolling back intentionally made breaking changes $release"
git apply allowed_breaking_change.patch
fi
curl -sSL https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity.did -o internet_identity_previous.did
didc check src/internet_identity/internet_identity.did internet_identity_previous.did
16 changes: 0 additions & 16 deletions allowed_breaking_change.patch

This file was deleted.

0 comments on commit 0558bdf

Please sign in to comment.