Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test slack integration #186

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows-source/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,10 @@ jobs:
steps:
- <<: *before-script
- <<: *checkout
uses: actions/checkout@v3 # v4 does not work with bazel-runner-large
if : ${{ github.event_name == 'pull_request' }}
with:
fetch-depth: 256
- <<: *checkout
uses: actions/checkout@v3
if : ${{ github.event_name != 'pull_request' }}
- <<: *docker-ro-login
- name: Run Bazel Test All
Expand Down Expand Up @@ -160,12 +158,10 @@ jobs:
steps:
- <<: *before-script
- <<: *checkout
uses: actions/checkout@v3 # v4 does not work with bazel-runner-large
if : ${{ github.event_name == 'pull_request' }}
with:
fetch-depth: 256
- <<: *checkout
uses: actions/checkout@v3
if : ${{ github.event_name != 'pull_request' }}
- <<: *docker-ro-login
- name: Run bazel build --config=check //rs/...
Expand Down Expand Up @@ -282,12 +278,10 @@ jobs:
steps:
- <<: *before-script
- <<: *checkout
uses: actions/checkout@v3 # v4 does not work with bazel-runner-large
if : ${{ github.event_name == 'pull_request' }}
with:
fetch-depth: 256
- <<: *checkout
uses: actions/checkout@v3
if : ${{ github.event_name != 'pull_request' }}
- <<: *docker-ro-login
- name: Run Build IC
Expand Down Expand Up @@ -346,11 +340,11 @@ jobs:
- <<: *before-script
- <<: *checkout
- name: Download bazel-targets [bazel-test-all]
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bazel-targets
- name: Download build-ic.tar [build-ic]
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build-ic
- name: Build Determinism Test
Expand All @@ -368,7 +362,7 @@ jobs:

cargo-clippy-linux:
name: Cargo Clippy Linux
<<: *dind-large-setup
Copy link
Member

@marko-k0 marko-k0 Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave this on dind-large-setup. It takes quite some resources so it's safer to have it on dind-large-setup. Ignore the comment if you're just testing the slack though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore this PR, I was testing something out before, then reused it to test the slack integration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgundy test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfinity/idx test

<<: *bazel-small-setup
steps:
- <<: *before-script
- <<: *checkout
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ jobs:
if [ -e /__w/cache ]; then sudo ln -s /__w/cache /; fi
if [ -n "${NODE_NAME:-}" ]; then echo "Node: $NODE_NAME"; fi
- name: Checkout
uses: actions/checkout@v3 # v4 does not work with bazel-runner-large
uses: actions/checkout@v4
if: ${{ github.event_name == 'pull_request' }}
with:
fetch-depth: 256
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
if: ${{ github.event_name != 'pull_request' }}
- name: Docker RO SA login
id: docker-ro-login
Expand Down Expand Up @@ -109,12 +109,12 @@ jobs:
if [ -e /__w/cache ]; then sudo ln -s /__w/cache /; fi
if [ -n "${NODE_NAME:-}" ]; then echo "Node: $NODE_NAME"; fi
- name: Checkout
uses: actions/checkout@v3 # v4 does not work with bazel-runner-large
uses: actions/checkout@v4
if: ${{ github.event_name == 'pull_request' }}
with:
fetch-depth: 256
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
if: ${{ github.event_name != 'pull_request' }}
- name: Docker RO SA login
id: docker-ro-login
Expand Down Expand Up @@ -307,12 +307,12 @@ jobs:
if [ -e /__w/cache ]; then sudo ln -s /__w/cache /; fi
if [ -n "${NODE_NAME:-}" ]; then echo "Node: $NODE_NAME"; fi
- name: Checkout
uses: actions/checkout@v3 # v4 does not work with bazel-runner-large
uses: actions/checkout@v4
if: ${{ github.event_name == 'pull_request' }}
with:
fetch-depth: 256
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
if: ${{ github.event_name != 'pull_request' }}
- name: Docker RO SA login
id: docker-ro-login
Expand Down Expand Up @@ -386,11 +386,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Download bazel-targets [bazel-test-all]
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bazel-targets
- name: Download build-ic.tar [build-ic]
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build-ic
- name: Build Determinism Test
Expand All @@ -408,10 +408,10 @@ jobs:
cargo-clippy-linux:
name: Cargo Clippy Linux
runs-on:
labels: dind-runner-large
labels: bazel-runner-small
container:
image: ghcr.io/dfinity/ic-build@sha256:eb85228ebf7511e2589f86788345eb3d1c8144914a8a2fa771d4347ddacac413
timeout-minutes: 60
timeout-minutes: 45
if: ${{ vars.RUN_CI == 'true' }}
steps:
- name: Before script
Expand Down
Loading