chore(dependency-mgmt): format *.py files under ci/src/dependencies
#1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
approved these changes
Sep 30, 2024
tmu0
approved these changes
Sep 30, 2024
Agree, I will probably follow up in a separate PR as that might throw more errors in other files. |
andrewbattat
approved these changes
Sep 30, 2024
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…dfinity#1750) The code in `ci/src/dependencies` is not formatted properly. I used to rely on `bazel run //:ruff-format` but TIL it only does the lint fixes and doesn't do formatting. In this PR, - Update ruff to the latest version - Adapt warnings in pyproject.toml - Format files in `ci/src/dependencies` with `bazel run @ruff//:ruff format ci/src/dependencies` - An empty line lint fix in `ic-os/components/conformance_tests/check_file_references.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in
ci/src/dependenciesis not formatted properly. I used to rely onbazel run //:ruff-formatbut TIL it only does the lint fixes and doesn't do formatting.In this PR,
ci/src/dependencieswithbazel run @ruff//:ruff format ci/src/dependenciesic-os/components/conformance_tests/check_file_references.py