chore: [MR-569] Drop old canister queue implementations #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the proto and Rust definitions were kept around for backward compatibility (decoding canister queues encoded by old replica versions). Now that all of mainnet is running a replica version using and encoding the new CanisterQueues, it is safe to remove the old ones.
alin-at-dfinity
requested review from
stiegerc,
derlerd-dfinity and
oggy-dfin
stiegerc
approved these changes
Sep 30, 2024
derlerd-dfinity
approved these changes
Oct 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
[MR-569]: Both the proto and Rust definitions were kept around for backward compatibility (decoding canister queues encoded by old replica versions). Now that all of mainnet is running a replica version using and encoding the new `CanisterQueues`, it is safe to remove the old ones. [MR-569]: https://dfinity.atlassian.net/browse/MR-569?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MR-569: Both the proto and Rust definitions were kept around for backward compatibility (decoding canister queues encoded by old replica versions). Now that all of mainnet is running a replica version using and encoding the new
CanisterQueues, it is safe to remove the old ones.