Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(IDX): update CI env vars #1703

Merged
merged 17 commits into from
Oct 1, 2024
Merged

refactor(IDX): update CI env vars #1703

merged 17 commits into from
Oct 1, 2024

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Sep 26, 2024 •
edited
Loading

Github Actions does not expose job_id, so we were using job_id and job_name interchangeably. To simplify, we replace CI_JOB_ID with CI_JOB_NAME and also update then name of ROOT_PIPELINE_ID to CI_RUN_ID.

@cgundy cgundy marked this pull request as ready for review September 26, 2024 14:03
@cgundy cgundy requested a review from a team as a code owner September 26, 2024 14:03
@github-actions github-actions bot added the @idx label Sep 26, 2024
@cgundy cgundy changed the title refactor(IDX): remove CI_JOB_ID var refactor(IDX): update CI env vars Sep 26, 2024
@cgundy cgundy requested a review from marko-k0 October 1, 2024 09:08
marko-k0
marko-k0 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@marko-k0 marko-k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd probably run all bazel targets with these changes.

@cgundy cgundy added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Oct 1, 2024
@cgundy cgundy added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit f6bbaa4 Oct 1, 2024
26 checks passed
@cgundy cgundy deleted the remove-job-id branch October 1, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-k0 marko-k0 marko-k0 approved these changes

Assignees
No one assigned
Labels
CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @idx refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgundy @marko-k0