Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-1474): Config types refactor #1667

Merged
merged 9 commits into from
Oct 3, 2024
Merged

refactor(NODE-1474): Config types refactor #1667

merged 9 commits into from
Oct 3, 2024
+101 −56

Conversation

andrewbattat
Copy link
Member

@andrewbattat andrewbattat commented Sep 24, 2024 •
edited
Loading

NODE-1474

  • Create NetworkSettings enums.
  • Move mgmt_mac to a newly created ICOSDevSettings struct.
  • Rename GuestosDevConfig to GuestosDevSettings for consistency.
  • Update certain config values to closely match types in Replica config (eg: backup_retention_time_seconds)

@andrewbattat andrewbattat self-assigned this Sep 24, 2024
@andrewbattat andrewbattat changed the title Create ICOSDevSettings and move mgmt_mac to struct chore: Create ICOSDevSettings and move mgmt_mac to struct Sep 24, 2024
@github-actions github-actions bot added the chore label Sep 24, 2024
@andrewbattat andrewbattat marked this pull request as ready for review September 24, 2024 22:36
@andrewbattat andrewbattat requested a review from a team as a code owner September 24, 2024 22:36
@github-actions github-actions bot added the @node label Sep 24, 2024
@andrewbattat andrewbattat changed the title chore: Create ICOSDevSettings and move mgmt_mac to struct chore(NODE-1474): Create ICOSDevSettings and move mgmt_mac to struct Sep 25, 2024
@andrewbattat andrewbattat changed the title chore(NODE-1474): Create ICOSDevSettings and move mgmt_mac to struct chore(NODE-1474): Create ICOSDevSettings and move mgmt_mac to struct, updating naming and type values Sep 25, 2024
@andrewbattat andrewbattat changed the title chore(NODE-1474): Create ICOSDevSettings and move mgmt_mac to struct, updating naming and type values chore(NODE-1474): Config types refactor Sep 30, 2024
@andrewbattat andrewbattat changed the title chore(NODE-1474): Config types refactor refactor(NODE-1474): Config types refactor Sep 30, 2024
@github-actions github-actions bot added refactor and removed chore labels Sep 30, 2024
Bownairo
Bownairo reviewed Oct 2, 2024
View reviewed changes
rs/ic_os/config/src/main.rs Show resolved Hide resolved
rs/ic_os/config/src/types.rs Show resolved Hide resolved
rs/ic_os/config/src/types.rs Outdated Show resolved Hide resolved
Bownairo
Bownairo approved these changes Oct 3, 2024
View reviewed changes
rs/ic_os/config/src/types.rs Show resolved Hide resolved
@andrewbattat andrewbattat added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit a7d5b71 Oct 3, 2024
24 checks passed
@andrewbattat andrewbattat deleted the andrew/refactor-mgmt_mac-types branch October 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bownairo Bownairo Bownairo approved these changes

@frankdavid frankdavid Awaiting requested review from frankdavid

Assignees

@andrewbattat andrewbattat

Labels
@node refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewbattat @frankdavid @Bownairo