-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ICRC_ledger): FI-1397: Add transaction generation to ICRC golden state tests #1478
Merged
mbjorkqvist
merged 18 commits into
master
from
mathias-FI-1397-add-transaction-generation-to-icrc-golden-state-tests
Sep 24, 2024
Merged
test(ICRC_ledger): FI-1397: Add transaction generation to ICRC golden state tests #1478
mbjorkqvist
merged 18 commits into
master
from
mathias-FI-1397-add-transaction-generation-to-icrc-golden-state-tests
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-icrc-golden-state-tests # Conflicts: # rs/rosetta-api/icrc1/ledger/sm-tests/src/in_memory_ledger.rs # rs/rosetta-api/icrc1/tests/golden_state_upgrade_downgrade.rs
maciejdfinity
approved these changes
Sep 17, 2024
The FI nightly test job successfully ran all the tests here. |
mbjorkqvist
deleted the
mathias-FI-1397-add-transaction-generation-to-icrc-golden-state-tests
branch
September 24, 2024 06:53
frankdavid
pushed a commit
that referenced
this pull request
Sep 25, 2024
… state tests (#1478) Add generation of transactions to the ICRC tests with golden ledger state. Also only run the extensive testing (verifying the ledger internal state wrt. allowances and balances, and generating transactions), for only one ledger per test.
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
… state tests (dfinity#1478) Add generation of transactions to the ICRC tests with golden ledger state. Also only run the extensive testing (verifying the ledger internal state wrt. allowances and balances, and generating transactions), for only one ledger per test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generation of transactions to the ICRC tests with golden ledger state. Also only run the extensive testing (verifying the ledger internal state wrt. allowances and balances, and generating transactions), for only one ledger per test.