Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ICRC_ledger): FI-1397: Add transaction generation to ICRC golden state tests #1478

Conversation

mbjorkqvist
Copy link
Member

@mbjorkqvist mbjorkqvist commented Sep 13, 2024

Add generation of transactions to the ICRC tests with golden ledger state. Also only run the extensive testing (verifying the ledger internal state wrt. allowances and balances, and generating transactions), for only one ledger per test.

@github-actions github-actions bot added the test label Sep 13, 2024
@mbjorkqvist
Copy link
Member Author

The FI nightly test job successfully ran all the tests here.

@mbjorkqvist mbjorkqvist marked this pull request as ready for review September 20, 2024 14:55
@mbjorkqvist mbjorkqvist requested a review from a team as a code owner September 20, 2024 14:55
@mbjorkqvist mbjorkqvist added this pull request to the merge queue Sep 24, 2024
Merged via the queue into master with commit abd1aa2 Sep 24, 2024
58 of 59 checks passed
@mbjorkqvist mbjorkqvist deleted the mathias-FI-1397-add-transaction-generation-to-icrc-golden-state-tests branch September 24, 2024 06:53
frankdavid pushed a commit that referenced this pull request Sep 25, 2024
… state tests (#1478)

Add generation of transactions to the ICRC tests with golden ledger
state. Also only run the extensive testing (verifying the ledger
internal state wrt. allowances and balances, and generating
transactions), for only one ledger per test.
levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
… state tests (dfinity#1478)

Add generation of transactions to the ICRC tests with golden ledger
state. Also only run the extensive testing (verifying the ledger
internal state wrt. allowances and balances, and generating
transactions), for only one ledger per test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants