feat(system-api): add call_cycles_add128_up_to
#1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @mraszyk for spec compliance check. |
dsarlis
approved these changes
Aug 28, 2024
mraszyk
reviewed
Aug 28, 2024
mraszyk
reviewed
Aug 28, 2024
mraszyk
approved these changes
Aug 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
#1319) This reverts commit 66c25e6. The `dst` output parameter could make it problematic for a higher-level language. Such output parameters typically result in unexpected allocs in C bindings from a managed language making the subsequent `call_perform` likely to fail. On the other hand, one can derive the value of the `dst` output parameter by computing the difference in canister cycles balance before and after calling `call_cycles_add128_up_to` (confirmed empirically) which might allow us to avoid the output parameter.
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
Introduces `call_cycles_add128_up_to` to the system API to offer a way of adding as many cycles as possible to a call without trapping in the subsequent `call_perform`. Corresponding spec MR: dfinity/interface-spec#316 Closes [SDK-1761](https://dfinity.atlassian.net/browse/SDK-1761?atlOrigin=eyJpIjoiY2QyZTJiZDRkNGZhNGZlMWI3NzRkNTBmZmVlNzNiZTkiLCJwIjoianN3LWdpdGxhYi1pbnQifQ) [SDK-1761]: https://dfinity.atlassian.net/browse/SDK-1761?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…y#1158)" (dfinity#1319) This reverts commit 66c25e6. The `dst` output parameter could make it problematic for a higher-level language. Such output parameters typically result in unexpected allocs in C bindings from a managed language making the subsequent `call_perform` likely to fail. On the other hand, one can derive the value of the `dst` output parameter by computing the difference in canister cycles balance before and after calling `call_cycles_add128_up_to` (confirmed empirically) which might allow us to avoid the output parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
call_cycles_add128_up_toto the system API to offer a way of adding as many cycles as possible to a call without trapping in the subsequentcall_perform.Corresponding spec MR: dfinity/interface-spec#316
Closes SDK-1761