-
Notifications
You must be signed in to change notification settings - Fork 316
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'gdemay/XC-96-ckerc20-withdrawal-without-reimbursements'…
… into 'master' feat(ckerc20): ckERC20 withdrawals without reimbursement of transaction fees [override-didc-check] (XC-96): Follow-up on [MR-18621](https://gitlab.com/dfinity-lab/public/ic/-/merge_requests/18621) to improve the user experience during a ckERC20 withdrawal 1. No longer require a high minimum ckETH withdrawal amount, which was previously set to `30_000_000_000_000_000` Wei (roughly 100 USD), to be able to make a ckERC20 withdrawal. Instead, the current gas fee is retrieved only if the current estimate is too old, and the necessary amount of ckETH will be burned to pay for the transaction fee. 2. Although the minter still needs to over-estimate the transaction fee, to ensure that future transactions are not blocked, the resulting transaction fee is in the same order of magnitude as the effective transaction fee (typically within a factor 2) and this MR therefore simplifies the withdrawal flow further by no longer reimbursing unspent transaction fees for ckERC20 withdrawals. Remark on `[override-didc-check]`: the changes in the Candid interface only impact the ckERC20 feature that is not yet released and are therefore not breaking. See merge request dfinity-lab/public/ic!18632
- Loading branch information
Showing
14 changed files
with
463 additions
and
270 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.