Skip to content

Commit

Permalink
Merge branch 'mirroring-eichhorl/cleanup-ecdsa-dealings' into 'master'
Browse files Browse the repository at this point in the history
chore(github-sync): PR#313 / fix(schnorr): CON-1257 Remove leftover uses of `ComputeInitialEcdsaDealings`

[GitHub PR 313](#313) (branch: eichhorl/cleanup-ecdsa-dealings) 

See merge request dfinity-lab/public/ic!20263
  • Loading branch information
marko-k0 committed Jul 5, 2024
2 parents 40b3b67 + 99e32fa commit a2fa6f8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion rs/consensus/src/consensus/batch_delivery.rs
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ pub fn generate_responses_to_sign_with_ecdsa_calls(
consensus_responses
}

/// Creates responses to `ComputeInitialEcdsaDealingsArgs` system calls with the initial
/// Creates responses to `ComputeInitialIDkgDealingsArgs` system calls with the initial
/// dealings.
fn generate_responses_to_initial_dealings_calls(
ecdsa_payload: &idkg::EcdsaPayload,
Expand Down
2 changes: 1 addition & 1 deletion rs/consensus/src/ecdsa/payload_builder/resharing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ mod tests {
ic_types::batch::ConsensusResponse::new(
callback_id,
ic_types::messages::Payload::Data(
ic_management_canister_types::ComputeInitialEcdsaDealingsResponse {
ic_management_canister_types::ComputeInitialIDkgDealingsResponse {
initial_dkg_dealings: initial_dealings.into(),
}
.encode(),
Expand Down
4 changes: 2 additions & 2 deletions rs/consensus/src/ecdsa/payload_verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,9 @@ fn validate_reshare_dealings(
for (request, config) in prev_payload.ongoing_xnet_reshares.iter() {
if !curr_payload.ongoing_xnet_reshares.contains_key(request) {
if let Some(response) = new_reshare_agreement.get(request) {
use ic_management_canister_types::ComputeInitialEcdsaDealingsResponse;
use ic_management_canister_types::ComputeInitialIDkgDealingsResponse;
if let ic_types::messages::Payload::Data(data) = &response.payload {
let dealings_response = ComputeInitialEcdsaDealingsResponse::decode(data)
let dealings_response = ComputeInitialIDkgDealingsResponse::decode(data)
.map_err(|err| {
InvalidEcdsaPayloadReason::DecodingError(format!("{:?}", err))
})?;
Expand Down

0 comments on commit a2fa6f8

Please sign in to comment.