feat: json reviver and replacer utils #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lmuntaner
approved these changes
Aug 14, 2023
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Aug 14, 2023
# Motivation JSON reviver and replacer have been copied / moved to `@dfinity/utils` # PRs - [x] dfinity/ic-js#396 # Changes - replace source for reviver and replacer - bump ic-js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The other day I was that close to use these functions we are using in NNS Dapp in another project. Ultimately I did not but it can be someday useful for the community to use these JSON reviver and replacer. That's why it's cool to move these from the dapp to the utils lib.
Changes