Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sns disburse maturity function #395

Merged
merged 12 commits into from
Aug 9, 2023
Merged

Sns disburse maturity function #395

merged 12 commits into from
Aug 9, 2023

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Aug 8, 2023 •
edited
Loading

Motivation

Add disburseMaturity to sns functions

Changes

  • disburseMaturity function
  • related types
  • increased size limit for sns: 14Kb -> 16Kb

Tests

  • disburseMaturity params spec

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.84 KB (0%)
@dfinity/cmc 998 B (0%)
@dfinity/ledger 2.51 KB (0%)
@dfinity/nns 30.8 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 13.7 KB (+0.38% 🔺)
@dfinity/utils 3.74 KB (0%)
@dfinity/rosetta-client -19 B (0%)
@dfinity/ic-management 2.04 KB (0%)

lmuntaner
lmuntaner reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it also in the wrapper? Thanks!

@mstrasinskis
Copy link
Contributor Author

Can you add it also in the wrapper? Thanks!

Good catch! Updated, thank you!

lmuntaner
lmuntaner approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mstrasinskis mstrasinskis merged commit 223d9da into main Aug 9, 2023
9 checks passed
@mstrasinskis mstrasinskis deleted the sns-disburseMaturity-function branch August 9, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @lmuntaner