New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Expose init response type #390

Merged

lmuntaner merged 1 commit into main from chore_LM_expose-types

Aug 2, 2023

Contributor

lmuntaner commented Aug 2, 2023

Motivation

Add new fields from the SNS aggregator.

In this PR: Expose the GetInitResponse. Which is a new (non used yet) field of the SNS aggregator.

Changes

Expose GetInitResponse type as SnsGetInitResponse

Tests

Not applicable


          Chore: Expose init response type

baca400

lmuntaner requested a review from peterpeterparker

August 2, 2023 13:31

Contributor Author

lmuntaner commented Aug 2, 2023

@peterpeterparker please review

Contributor

github-actions bot commented Aug 2, 2023

size-limit report 📦

Path	Size
@dfinity/ckbtc	7.84 KB (0%)
@dfinity/cmc	998 B (0%)
@dfinity/ledger	2.51 KB (0%)
@dfinity/nns	30.79 KB (0%)
@dfinity/nns-proto	76.3 KB (0%)
@dfinity/sns	13.39 KB (0%)
@dfinity/utils	3.74 KB (0%)
@dfinity/rosetta-client	-19 B (0%)
@dfinity/ic-management	2.04 KB (0%)

peterpeterparker approved these changes

View reviewed changes

Member

peterpeterparker left a comment

LGTM, thx

lmuntaner merged commit 1be050b into main

9 checks passed

lmuntaner deleted the chore_LM_expose-types branch

August 2, 2023 14:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet