Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump agent-js v0.18.1 #387

Merged
merged 5 commits into from
Jul 24, 2023
Merged

build: bump agent-js v0.18.1 #387

merged 5 commits into from
Jul 24, 2023

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Jul 24, 2023

Motivation

Bump agent-js version to v0.18.1. This is required to resolve an "endless loop issue" when the ic-mgmt library is used to request the statuses of canister for which the caller is not a controler.

"endless loop" because from obversation it seems to ends after 5min.

Note

Will be integrated in NNS dapp (dfinity/nns-dapp#2950) to solve similar issue.

Changes

  • bump agent-js last version
  • add a script npm run update:agent to update all peer dependencies of the libs that use agent-js

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 7.84 KB (0%)
@dfinity/cmc 998 B (0%)
@dfinity/ledger 2.51 KB (0%)
@dfinity/nns 30.25 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 13.39 KB (0%)
@dfinity/utils 3.74 KB (0%)
@dfinity/rosetta-client -19 B (0%)
@dfinity/ic-management 2.04 KB (0%)

Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit affe5ea into main Jul 24, 2023
9 checks passed
@peterpeterparker peterpeterparker deleted the build/agent-js-v0-18-1 branch July 24, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants