feat: ICRC Index canister next gen #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/ledger-index-next-gen # Conflicts: # packages/ledger/src/index.ts
size-limit report 📦
|
… feat/ledger-index-next-gen # Conflicts: # packages/ledger/src/types/index.params.ts
|
The Snses are finally able to use the |
lmuntaner
reviewed
Mar 4, 2024
This was referenced Mar 4, 2024
peterpeterparker
added a commit
that referenced
this pull request
Mar 4, 2024
# Motivation `index-ng` isn't backwards compatible and introduces an issue in NNS dapp when calling "old index" canister: ``` Sorry, there was an error loading the transactions for this account. Cannot find required field balance ``` This PR reverts the code changes to support the index-ng canister that were merged in `main`. Those PRs were: - #380 - #561
peterpeterparker
added a commit
that referenced
this pull request
Mar 5, 2024
…-icrc (#562) # Motivation Provide support for the `index-ng` canister in `@dfinity/ledger-icrc`. # Notes The support was originally introduced as a replacement of the existing `IndexCanister` but, after testing a next release, we figured out it introduced a breaking changes as a variable `balance` was added as a non optional argument in the `GetTransactions` results. This lead to following error when the canister was using to query "old-index" canister: ``` Sorry, there was an error loading the transactions for this account. Cannot find required field balance ``` That's why ultimately we decided to introduce support for the `index-ng` canister in a dedicated module. # Previous PRs For tracability: - #380 - #561 - #564 # Changes - use `index-ng/index-ng.did` as source for the Index-ng canister - extract an interface for `icrc_balance_of` for Index-ng and ledger canister (we assume in the future there might be other duplicate functions that are shared by both canisters) - Implement `getTransactions` which accept queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use the Index canister "next gen", implement
balancefor Index canister and make fetching transactions available asquery.Changes
index-ng/index-ng.didas source for the Index canisterbalancefor Index canistergetTransactionsaccept queries