Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new address type support to ckbtc #370

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Add new address type support to ckbtc #370

merged 7 commits into from
Oct 12, 2023

Conversation

leokazz
Copy link
Contributor

@leokazz leokazz commented Jun 30, 2023 •
edited
Loading

Motivation

ckBTC now support p2tr and p2wsh adresses.

peterpeterparker
peterpeterparker reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

Two minor comments

packages/ckbtc/src/utils/btc.utils.ts Outdated Show resolved Hide resolved
packages/ckbtc/src/utils/btc.utils.ts Outdated Show resolved Hide resolved
@peterpeterparker peterpeterparker mentioned this pull request Oct 11, 2023
Merged
1 task
@peterpeterparker
Copy link
Member

@leokazz can you update your PR that way we can merge it as well?

I guess those are now live so it would be worth updating the lib and NNS dapp. Also in #450 we are updating the did file that also contains p2tr and p2wsh adresses.

peterpeterparker
peterpeterparker approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@peterpeterparker peterpeterparker merged commit 5273278 into dfinity:main Oct 12, 2023
9 checks passed
@peterpeterparker
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leokazz @peterpeterparker