Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add canister management methods to ic management library #368

Merged
merged 3 commits into from
Jun 29, 2023
Merged

feat: add canister management methods to ic management library #368

merged 3 commits into from
Jun 29, 2023

Conversation

nathanosdev
Copy link
Member

Motivation

Create a common JavaScript interface for interacting with the IC's management canister. This is something that I think will be particularly useful in tests or automation scripts.

Changes

I've extended the library that @peterpeterparker added with additional functions from the IC management canister interface.

Tests

I've added unit tests for each additional function.

@nathanosdev nathanosdev marked this pull request as ready for review June 28, 2023 14:22
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!! Just few ultra minor questions.

package-lock.json Outdated Show resolved Hide resolved
packages/ic-management/src/ic-management.canister.ts Outdated Show resolved Hide resolved
packages/ic-management/src/types/ic-management.params.ts Outdated Show resolved Hide resolved
packages/ic-management/src/types/ic-management.params.ts Outdated Show resolved Hide resolved
packages/utils/src/types/actor-type.utils.ts Show resolved Hide resolved
use arrow functions, create separate type for complex return type and use text version of management canister id
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a ton!

@peterpeterparker peterpeterparker merged commit 8f9e466 into dfinity:main Jun 29, 2023
8 checks passed
@peterpeterparker
Copy link
Member

@nathanosdev I have released a next version if you want to use it before we release an "official" version.

npm i @dfinity/utils@next @dfinity/ic-management@next

@nathanosdev nathanosdev deleted the nathan/add-canister-management-methods branch June 29, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants