Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix / diagnose the "not yet computed rollout" problem. #49

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

DFINITYManu
Copy link
Collaborator

Two things happen in this PR:

  1. An endpoint to fetch the internal cache is added, in order to help diagnose any logic errors that may be causing the API to return "not yet computed rollout" for rollouts started during the weekend.
  2. The logic of when to fetch the rollout plan is changed to the task evaluation loop.

I cannot reproduce this locally with Airflow so the hope is that item #1 in this PR will help diagnose next week if the problem is not resolved by #2.

Two things happen in this PR:

1. An endpoint to fetch the internal cache is added, in order to help diagnose any logic errors that may be causing the API to return "not yet computed rollout" for rollouts started during the weekend.
2. The logic of when to fetch the rollout plan is changed to the task evaluation loop.

I cannot reproduce this locally with Airflow so the hope is that item #1 in this PR will help diagnose next week if the problem is not resolved by #2.
@DFINITYManu DFINITYManu requested a review from a team as a code owner September 30, 2024 09:01
@DFINITYManu DFINITYManu merged commit 2bdd9c0 into main Sep 30, 2024
7 checks passed
@DFINITYManu DFINITYManu deleted the cacheinspect branch September 30, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants