Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publishing crates with correct versions #70

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Sep 20, 2024

Problem

When publishing canbench previously, I had to manually change the local dependencies to point to the versions in cargo (e.g. when publishing canbench-rs, I need to change the dependency on canbench-rs-macros from the local folder to the new version of canbench-rs-macros that I just published). This process is messy and confusing, and is one of the things that wouldn't be intuitive to anyone publishing canbench in the future.

Solution

Update Cargo.toml such that, locally, it uses a folder, and when publishing, it uses a specific version. That way, publishing can be seamless and requires no local modifications moving forward.

@ielashi ielashi requested a review from a team as a code owner September 20, 2024 08:13
Copy link

github-actions bot commented Sep 20, 2024

canbench 🏋 (dir: examples/btreemap_vs_hashmap)

No significant performance changes detected ✅

examples/btreemap_vs_hashmap/canbench_results.yml is up to date ✅


---------------------------------------------------

Benchmark: insert_users
  total:
    instructions: 2.57 B (no change)
    heap_increase: 871 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: remove_users
  total:
    instructions: 2.07 B (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: pre_upgrade_bench
  total:
    instructions: 743.98 M (-0.00%) (change within noise threshold)
    heap_increase: 519 pages (no change)
    stable_memory_increase: 184 pages (no change)

  serialize_state (scope):
    instructions: 729.04 M (-0.00%) (change within noise threshold)
    heap_increase: 519 pages (no change)
    stable_memory_increase: 0 pages (no change)

  writing_to_stable_memory (scope):
    instructions: 14.93 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 184 pages (no change)

---------------------------------------------------

Copy link

github-actions bot commented Sep 20, 2024

canbench 🏋 (dir: examples/fibonacci)

No significant performance changes detected ✅

examples/fibonacci/canbench_results.yml is up to date ✅


---------------------------------------------------

Benchmark: fibonacci_20
  total:
    instructions: 2224 (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: fibonacci_45
  total:
    instructions: 3011 (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@dsarlis dsarlis enabled auto-merge (squash) October 1, 2024 14:34
@dsarlis dsarlis merged commit 97610b6 into main Oct 1, 2024
10 checks passed
@dsarlis dsarlis deleted the ielashi/cargo_fix branch October 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants