-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flags to specify a custom runtime. #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem To enable running canbench smoothly in the `ic` repo, it is desirable to able to run canbench with the runtime (PocketIC) that is in the same commit as the PR. canbench didn't provide that flexibility, as it always downloaded and verified that the runtime has a specific hash. ## Solution Add two flags, one to set the path to the runtime, and another to skip the hash verification step altogether.
|
|
dsarlis
approved these changes
Sep 12, 2024
ielashi
changed the title
feat: add flags to set a custom runtime.
feat: add flags to specify a custom runtime.
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To enable running canbench without flakiness in the
ic
repo, it is desirable to able to specify a path for the runtime (pocket ic) to use. canbench didn't provide that flexibility, as it always downloads the runtime from the network.Solution
Add two flags, one to set the path to the runtime, and another to skip the hash verification step altogether.