Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flags to specify a custom runtime. #66

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Sep 12, 2024

Problem

To enable running canbench without flakiness in the ic repo, it is desirable to able to specify a path for the runtime (pocket ic) to use. canbench didn't provide that flexibility, as it always downloads the runtime from the network.

Solution

Add two flags, one to set the path to the runtime, and another to skip the hash verification step altogether.

## Problem
To enable running canbench smoothly in the `ic` repo, it is desirable to
able to run canbench with the runtime (PocketIC) that is in the same
commit as the PR. canbench didn't provide that flexibility, as it always
downloaded and verified that the runtime has a specific hash.

## Solution
Add two flags, one to set the path to the runtime, and another to skip
the hash verification step altogether.
Copy link

github-actions bot commented Sep 12, 2024

canbench 🏋 (dir: examples/fibonacci)

No significant performance changes detected ✅

examples/fibonacci/canbench_results.yml is up to date ✅


---------------------------------------------------

Benchmark: fibonacci_20
  total:
    instructions: 2224 (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: fibonacci_45
  total:
    instructions: 3011 (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Copy link

github-actions bot commented Sep 12, 2024

canbench 🏋 (dir: examples/btreemap_vs_hashmap)

No significant performance changes detected ✅

examples/btreemap_vs_hashmap/canbench_results.yml is up to date ✅


---------------------------------------------------

Benchmark: insert_users
  total:
    instructions: 2.57 B (no change)
    heap_increase: 871 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: remove_users
  total:
    instructions: 2.07 B (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: pre_upgrade_bench
  total:
    instructions: 743.98 M (-0.00%) (change within noise threshold)
    heap_increase: 519 pages (no change)
    stable_memory_increase: 184 pages (no change)

  serialize_state (scope):
    instructions: 729.04 M (-0.00%) (change within noise threshold)
    heap_increase: 519 pages (no change)
    stable_memory_increase: 0 pages (no change)

  writing_to_stable_memory (scope):
    instructions: 14.93 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 184 pages (no change)

---------------------------------------------------

@ielashi ielashi enabled auto-merge (squash) September 18, 2024 12:21
@ielashi ielashi changed the title feat: add flags to set a custom runtime. feat: add flags to specify a custom runtime. Sep 18, 2024
@ielashi ielashi enabled auto-merge (squash) September 18, 2024 12:21
@ielashi ielashi merged commit 30b6352 into main Sep 18, 2024
12 checks passed
@ielashi ielashi deleted the ielashi/custom_runtime branch September 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants