Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 0.15.0 - DO NOT MERGE #4

Draft
wants to merge 4 commits into
base: upstream-0.15.0
Choose a base branch
from
Draft

Conversation

Ali-Piccioni
Copy link

@Ali-Piccioni Ali-Piccioni commented Dec 23, 2022

This branch patches the rules rust 0.15.0 with DFINITY's changes.

This pull request's file changed shows a diff between patch-0.15.0 and upstream-0.15.0. You can also produce the diff with

git diff upstream-0.15.0 patch-0.15.0

@Ali-Piccioni Ali-Piccioni changed the base branch from main to upstream-0.15.0 December 23, 2022 08:12
@Ali-Piccioni Ali-Piccioni changed the title Patch 0.15.0 Patch 0.15.0 - DO NOT MERGE Dec 23, 2022
@Ali-Piccioni Ali-Piccioni marked this pull request as draft December 23, 2022 08:15
This is a "temporary" workaround because during consolidation, we may
merge crates in such a way as to cause a cyclic dependency.

For more details, see
rust-lang/rust-analyzer#13349
bazelbuild#1589
gitlab-dfinity pushed a commit to dfinity/ic that referenced this pull request Dec 23, 2022
upgrade to rules rust 0.15.0

Upgrade to DFINITY's fork of rules rust 0.15.0

See difference between upstream and fork here: dfinity-lab/rules_rust#4 

See merge request dfinity-lab/public/ic!9816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants