Dework integration #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crabsinger
reviewed
Jan 27, 2022
| public function up() | ||
| { | ||
| Schema::table('circles', function (Blueprint $table) { | ||
| $table->string('dework_organization_id')->nullable(); |
There was a problem hiding this comment.
I think a separate table with many-to-one support for external integratinos would be a more reusable model. Allowing for any number of external integrations.
There was a problem hiding this comment.
idk, if it is only one field...
I think it would attach to the protocol table
Is this id secret at all? if not, easier as we don't have to think about permissions for it.
And then, I wonder how the permissions work once in coordinape, the user needs an access token for both front ends.. hm
And like Zashton noted in coordinape discord:
This also needs to happen in hasura, as that is handling our migrations now
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.