Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANTWERP-2024] Pretalx => DoD Schedule Auto Update #14393

Closed
wants to merge 0 commits into from

Conversation

KrisBuytaert
Copy link
Contributor

Schedule updates for 2024-antwerp

Auto Release from Pretalx to DoD Schedule

Conference Hook System

@KrisBuytaert KrisBuytaert requested a review from a team as a code owner July 24, 2024 15:53
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit af03814
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/66ac81498182b00008acd04e
😎 Deploy Preview https://deploy-preview-14393--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is really large. Is there some kind of compression going on with the auto-generation system that didn't kick off?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, no, the auto generation system does not process images, it takes the images from Pretalx and uses them as is.
This means that a speaker uploading a large image, will be same image and the same size.
Once #14341 is merged, we can move to the images to the assets folder and then HugoIO will process them for the front end, while keeping the source

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in mind that while it will make the delivered image smaller, it will still be very large in the repo and the repo is already very large and challenging to clone on slower connections, etc. So i'm not sure that fully solves the issue.

Can it be done with the remote image feature of hugo assets, wherein the image is on pretalx side and served from there and doesn't have to be in the repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I do understand the large source problem, I have looked into the ConferenceHook taking larger images and scaling them down, however that I haven't had the time to implement that fully and even test that

As for you idea of a remote asset, yes that is actually possible, hugo-extended actually allows that and I have used it for another project, however I haven't tested that on a public setup, as in the other setup is a local setup where both source and target are always available, I am not sure what would happen if the resource is not found and how Hugo would react, or if it could just fall back to the default.

As this is not something I can solve quickly, can we get this PR merged and then we update the images to smaller ones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants