compiler: Minor tweaks for elastic code gen #2453
Open
+77
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2453 +/- ##
==========================================
- Coverage 87.01% 87.00% -0.01%
==========================================
Files 239 239
Lines 44958 44985 +27
Branches 8390 8394 +4
==========================================
+ Hits 39118 39140 +22
- Misses 5108 5113 +5
Partials 732 732 ☔ View full report in Codecov by Sentry. |
| @@ -687,6 +687,10 @@ def __init_finalize__(self, **kwargs): | |||
| if not configuration['safe-math']: | |||
| self.cflags.append('--use_fast_math') | |||
|
|
|||
| # Optionally print out per-kernel shared memory and register usage | |||
| if configuration['profiling'] == 'advanced2': | |||
mloubout
reviewed
Sep 11, 2024
| @@ -490,6 +491,11 @@ def _cache_key(cls, *args, **kwargs): | |||
| # From the kwargs | |||
| key.update(kwargs) | |||
|
|
|||
| # Any missing __rkwargs__ along with their default values | |||
| params = inspect.signature(cls.__init_finalize__).parameters | |||
There was a problem hiding this comment.
Ouch how can we end up in such a weird spot
There was a problem hiding this comment.
try the newly added tests without this patch 😬 I don't remember the details, but basically caching bypassed because a different cache key gets computed
EdCaunt
reviewed
Sep 11, 2024
| @@ -244,6 +246,20 @@ def add(self, expr, make, terms=None): | |||
| self[base] = self.extracted[base] = make() | |||
|
|
|||
|
|
|||
| def subs_if_composite(expr, subs): | |||
| """ | |||
| Call `expr.subs(subs)` if `subs` contain composite expressions, that is | |||
EdCaunt
reviewed
Sep 17, 2024
| @@ -233,7 +233,7 @@ def make_stencil_dimension(expr, _min, _max): | |||
| Create a StencilDimension for `expr` with unique name. | |||
| """ | |||
| n = len(expr.find(StencilDimension)) | |||
| return StencilDimension(name='i%d' % n, _min=_min, _max=_max) | |||
| return StencilDimension('i%d' % n, _min, _max) | |||
There was a problem hiding this comment.
Nitpick: could these just be min and max now?
FabioLuporini
force-pushed
the
opt-fd-interp-tmp
branch
from
8eef1a1
to
7f99f6c
Compare
FabioLuporini
force-pushed
the
opt-fd-interp-tmp
branch
from
7f99f6c
to
602c448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.