types: Introduce abstract class LocalType #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 236 236
Lines 44899 44900 +1
Branches 8363 8361 -2
=======================================
+ Hits 39069 39071 +2
+ Misses 5101 5100 -1
Partials 729 729 ☔ View full report in Codecov by Sentry. |
EdCaunt
approved these changes
Jul 31, 2024
enwask
reviewed
Jul 31, 2024
devito/types/basic.py
Outdated
|
|
||
| Notes | ||
| ----- | ||
| Subclasses should setup `liveness`. |
|
|
||
| def __init_finalize__(self, *args, **kwargs): | ||
| self._liveness = kwargs.setdefault('liveness', 'lazy') | ||
| super().__init_finalize__(*args, **kwargs) |
There was a problem hiding this comment.
Is there a reason self._liveness is set before super().__init_finalize__()?
devito/types/object.py
Outdated
| @@ -235,21 +231,12 @@ def _C_free(self): | |||
| """ | |||
| return None | |||
|
|
|||
| _C_modifier = None | |||
| """ | |||
| A modifier added to the LocalObject's C declaration when the object appears | |||
| in a function signature. For example, a subclass might define `_C_modifier = '&'` | |||
| to impose pass-by-reference semantics. | |||
| """ | |||
There was a problem hiding this comment.
Move this docstring to LocalType? Not sure why it was below _C_modifier instead of above in the first place
| in a function signature. For example, a subclass might define `_C_modifier = '&'` | ||
| to impose pass-by-reference semantics. | ||
| """ | ||
| _C_modifier = None |
There was a problem hiding this comment.
FWIW, with the advent of CustomDType this might not be necessary anymore. Have a look maybe when you got time (not for this PR)
FabioLuporini
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.