-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: scrum (original) #2192
base: develop
Are you sure you want to change the base?
new icon: scrum (original) #2192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, line version could be added if you like to try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quality of this PR is good, so great work with that!
Though I'm not sure if this icon should be accepted since there's no official icon for scrum.
@lunatic-fox @Panquesito7 @canaleal What do you guys think?
It fits according to our guidelines as far as i can tell, but there's no official icon for scrum.
https://github.com/devicons/devicon/wiki/What-Icons-Do-We-Accept%3F
I like the icon, but I don't think it should be included as there's no official version available. It might confuse others and lead to misunderstandings. |
Just found that SSH is also included in the collection which doesn't really have an official icon either, right? https://github.com/devicons/devicon/tree/master/icons/ssh |
That may be true, but we don't remove icons already in devicons unless they cause issues. We for example also have tech company logos that were added early on in the project, even though we no longer accept company logos (only technologies). Please check out What Icons Do We Accept? on the wiki to see more about which icons we do, and do not accept |
I'll wait for more feedback from @lunatic-fox and @Panquesito7 before closing or merging this PR |
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen hereThis PR closes #2191
Link to prove your SVG is correct and up-to-date.
There isn't really an official source for this.