Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't hide menu in casting profile #1590

Merged
merged 1 commit into from
Sep 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/usage/casting.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ Casting Home Assistant dashboards comes with a number of caveats:
- The Javascript fullscreen API does not work (so the fullscreen button does not
work, but see below for an equivalent).

## The `casting` profile

The optional [casting profile](../configuration/profiles.md?id=casting) provides
some defaults to improve your casting experience. Use it like:

```yaml
profiles:
- casting
```
## Recommended configuration for Nest Hub
Using a `panel` dashboard with the following base configuration will result in
Expand All @@ -38,6 +48,8 @@ cameras:
dimensions:
aspect_ratio: 1024:600
aspect_ratio_mode: static
profile:
- casting
```

### Result
Expand Down
2 changes: 0 additions & 2 deletions src/config/profiles/casting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@ import {
CONF_LIVE_CONTROLS_BUILTIN,
CONF_LIVE_SHOW_IMAGE_DURING_LOAD,
CONF_MEDIA_VIEWER_CONTROLS_BUILTIN,
CONF_MENU_STYLE,
} from '../../const.js';

export const CASTING_PROFILE = {
[CONF_MENU_STYLE]: 'none' as const,
[CONF_LIVE_AUTO_UNMUTE]: ['selected', 'visible'],
[CONF_DIMENSIONS_ASPECT_RATIO]: '16:9',
[CONF_LIVE_CONTROLS_BUILTIN]: false,
Expand Down
1 change: 0 additions & 1 deletion tests/config/profiles/casting.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ it('should contain expected defaults', () => {
'live.controls.builtin': false,
'live.show_image_during_load': true,
'media_viewer.controls.builtin': false,
'menu.style': 'none',
});
});

Expand Down
Loading