Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-410 feat: release 시 log 출력 일정 레벨(v,i,d) 막기 #214

Merged
merged 4 commits into from
Jul 8, 2023

Conversation

kimhyeing
Copy link
Contributor

@kimhyeing kimhyeing commented Jul 1, 2023

💁‍♂️ 변경 내용

AS-IS

  • release 앱에도 모든 로그가 출력되었습니다.

TO-BE

  • release 앱에는 v,i,d 레벨의 로그가 출력되지 않습니다.
  • okhttp의 HttpLoggingInterceptor가 debug에만 추가됩니다. (가장 낮은 레벨인 BASIC에도 api 주소가 출력되기때문에 release에선 interceptor 자체를 추가하지 않도록 하였습니다.)

📢 전달사항

@kimhyeing kimhyeing self-assigned this Jul 1, 2023
@kimhyeing kimhyeing requested a review from a team as a code owner July 1, 2023 14:01
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kimhyeing kimhyeing merged commit 1cc08fc into develop Jul 8, 2023
3 checks passed
@kimhyeing kimhyeing deleted the feature/DEP-410 branch July 8, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant