Switch from style to transformers #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rmarkdown as an alias for R so that lintr also is applied to R markdown files
|
Any news on that? No rush at all, but that's a straightforward modification for a fixer that already exist... If it helps, it was @w0rp who did the review of the code when I initially added |
w0rp
approved these changes
Nov 7, 2019
|
Cheers! 🍻 Sorry for the delay. I catch up on emails now and then. |
|
No problem, thanks a lot! |
AntoineGagne
added a commit
to AntoineGagne/ale
that referenced
this pull request
Nov 20, 2019
* master: Clean up the nimpretty code add nimpretty fixer Default errorview in pwsh7 now concise Add tagged entry for symbols to documentation Switch variables to dictionary key Add scriptencoding to `completion.vim` Fix typo Add documentation for ale-symbols feature Allow the user to set their own completion values Switch from style to transformers (dense-analysis#2838) Fix a test failing in AppVeyor Revert "Add definition of c/clangd's language as C (dense-analysis#2791)" Add nimcheck end_col options Allow the use of StandardX for StandardJS linting and fixing. See https://github.com/standard/standardx Remove standardts fixer in favor of allowing standard.vim fixer to handle JavaScript or TypeScript options. Make sure README and docs are synced. Add StandardJS for TypeScript linting and fixing. Fix crystal-lang non file-tied message handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styler package writers recommend using the
transformersargument rather than thestyleargument for more flexibility: r-lib/styler#500.This was also addressed in this issue: r-lib/styler#340.
It does not change the behavior for most users, but one can now do something like use
ale_r_styler_optionsto tweak specific elements of the fixer (e.g., dotidyverse_style(strict = FALSE)to change from the defaultstrict = TRUE) rather than having to change the whole style (e.g. change fromtidyverse_styleto something completely different). With the current code, only the later was allowed, and the former wasn't possible. With the PR, both are allowed.PS: Sorry for all the commits. My fork wasn't clean. It would be great if you could squash everything when merging.