Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modern deno streams #410

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Conversation

williamhorning
Copy link
Contributor

@williamhorning williamhorning commented Mar 23, 2024

instead of using the Deno.Reader and Deno.Writer apis, which are going to be removed in Deno 2.0, this PR moves towards using the ReadableStream and Writeable stream interfaces already available on the Deno.Conn interface. additionally, this removed the dependency on @std/io, which lightens the package a bit too

edit: not sure why tests are failing, they passed earlier when i was working on them locally

@williamhorning williamhorning marked this pull request as draft March 23, 2024 23:31
@williamhorning williamhorning marked this pull request as ready for review March 23, 2024 23:36
@lucsoft lucsoft merged commit eff419f into denodrivers:main Mar 23, 2024
5 checks passed
@williamhorning williamhorning deleted the modern-features branch March 23, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants