Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the visual representation of the battery level #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

csperle
Copy link

@csperle csperle commented Jul 10, 2020

Please take a look on this commit that changes the way the battery level is shown. The problem with the old indicator was, that it should show the battery level (if < 25) as a number in percent. The problem: the kindle 4 can not show the percent sign. This looked strange. See for more details:

https://www.mobileread.com/forums/showthread.php?t=278982

I wanted to change that into a visual representation drawing two rectangles on the screen, showing how full the battery is. Unfortunatelly also this command does not work on a kindle 4 (argh!). See:

https://wiki.mobileread.com/wiki/Eips

Now I am using characters showing a somewhat visual representation (enriched with the number):

|----25->==|

Only pull it, if you like it.

Because I only want to call the drawing command once, I used this odd looking switch-case structure instead of a fancy loop to generate the characters.

@dennisreimann
Copy link
Owner

To be honest I don't want to overcomplicate this part. I'm running the Kindle plugged in all the time, because my battery is too weak to run it for two days straight and other peoples experience seems to be along the same line.

@csperle
Copy link
Author

csperle commented Jul 13, 2020

Good point. I have enhanced the feature to only show the battery level if not plugged in.

But no worries for not pulling. I can rebase the feature when the development moves on to still show it on my kindle:)

@dennisreimann
Copy link
Owner

dennisreimann commented Jul 13, 2020

I'll leave this open for others to maybe chime in – but as you said, it's easy to apply this on a personal basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants