fix badly encoded %23 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbenitez
reviewed
Jan 28, 2024
adbenitez
approved these changes
Jan 28, 2024
|
i just added another commit to make the generator idempotent |
r10s
force-pushed
the
r10s/fix-bad-input
branch
from
3c4dbca
to
3677534
Compare
…ndom as multiple schemes are converted to one by browsers
|
yeah - now we can create the links with the generator also on iOS, just tested :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first # may be wrongly encoded to %23 by safari/iOS; convert it back
closes #16, closes #22