fix: chat "scrolling up" upon reaction #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-on-reaction-3
branch
from
6005ac7
to
92dca6e
Compare
nicodh
approved these changes
Sep 10, 2024
|
I was thinking of putting this into version |
|
Yes but it's easy to apply it to the new package/frontend source. So hopefully not too much work :-) |
|
I tested it by patching main since I have main already updated |
we can still back port it afterwards if the next release takes too long. I say rebase it and merge it to main now and write it into your notes for back porting, if we need to do that because the new release has delays. |
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-on-reaction-3
branch
2 times, most recently
from
fbaa7e6
to
6d3b21c
Compare
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-on-reaction-3
branch
from
6d3b21c
to
78d23f6
Compare
...resulting in new messages not getting scrolled into view when they arrive. This simply removes height changes between messages with / without a reaction. Closes #3753
WofWca
force-pushed
the
wofwca/fix-chat-scroll-up-on-reaction-3
branch
from
78d23f6
to
cf84e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...resulting in new messages not getting scrolled into view when they arrive.
This simply removes height changes between messages with / without a reaction.
Closes #3753