Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling light/dark mode menu #1251

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enabling light/dark mode menu #1251

wants to merge 4 commits into from

Conversation

sidharth30060
Copy link
Collaborator

@sidharth30060 sidharth30060 commented Sep 13, 2024

Description

Enabling light/dark mode menu in the navbar

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1476

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Sep 13, 2024

Test Results

76 tests  ±0   76 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9b2cc46. ± Comparison against base commit 38f8046.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sidharth30060 ,
Please add the screenshots of the output of the testing and map GitHub issue to the pull request, Changes looks good to me

@sidharth30060
Copy link
Collaborator Author

Light mode
Screenshot 2024-09-16 152956
Dark Mode
Screenshot 2024-09-16 153007

@prablr79
Copy link
Collaborator

@sidharth30060 can you create github issue and associate with this PR ? and make sure this branch is up to date with base branch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants