-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MS-DOS platform and Watcom compilers. #794
Conversation
They indeed should, and it looks like you've set it up that way. Can you explain what you mean by the logo not scaling right? I'll try to test locally soon. Also, be sure to see the black failures / run black locally if you want it to auto-fix the formatting issues. |
there are a bunch of (all?) compilers failing in the non-docker test, and 3 failing in the docker test. I'm not even sure if all 3 are new compilers either. very weird |
This PR closes #468 |
I think I've addressed the formatting and the comments relating to hard coded paths. I would like someone to verify the icon works correctly for them though before I take this out of draft. The issue I see is that it only displays the top left corner of the icon like its really zoomed in, but I thought I'd fixed that by adjusting the scaling in inkscape. |
The --reloc option seems to generate a lot of noise for the i686 objdump.
@OmniBlade lgtm, but black has a couple more issues to resolve. Also, if you could refrain from force-pushing, it helps reviewers keep track of new changes over time |
weird..other simple tests failed too in the most recent CI build. I'll look into it after the black things are fixed |
@OmniBlade I think the same issues still remain, or at least the same lines |
Provisional implementation, need some clarification on where the tools should actually go and if they should be pulled down in downloads.py as I currently have it or in the Dockerfile for the backend. Also, the MS-DOS icon isn't scaling right for me and I can't figure out how to fix it.