Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mapping completion in curations #767

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR adds the is_mapping_complete property to the returned collections. This property is set as true if:

  • There are items in the collection that don't have item curations done when the item had mappings.
  • There are no items in the collection.
    The item curations now have a property that contains information about if the mapping was complete when the curation was created or updated, that occurs when the item is published or changes over it are pushed, meaning that the item was published with the mapping changes.

@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 10602980420

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.352%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Collection/Collection.model.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10566809810: 0.03%
Covered Lines: 3091
Relevant Lines: 4182

💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit f6bf391 into master Aug 28, 2024
4 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/add-mapping-completion-in-curations branch August 28, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants