Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add is mapping complete property to TP items #765

Merged
merged 1 commit into from
Aug 26, 2024
Merged

feat: Add is mapping complete property to TP items #765

merged 1 commit into from
Aug 26, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR adds the isMappingComplete property to TP items which signals if the mapping is set in the Catalyst.

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 10560182792

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.324%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/mocks/items.ts 4 5 80.0%
Totals Coverage Status
Change from base Build 10389628405: 0.0%
Covered Lines: 3087
Relevant Lines: 4177
💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit 1d9d34d into master Aug 26, 2024
4 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/add-is-mapping-complete-to-item branch August 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyaiox cyaiox cyaiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LautaroPetaccio @cyaiox