feat: Return full updated items after upsert #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10388330869Details
💛 - Coveralls |
cyaiox
reviewed
Aug 14, 2024
| if (catalystItems.length > 0) { | ||
| item = Bridge.mergeTPItem(dbItem, collection, catalystItems[0]) | ||
| } | ||
| item = Bridge.mergeTPItem( |
There was a problem hiding this comment.
should this validation kept?
catalystItems.length > 0
There was a problem hiding this comment.
If there's no catalyst item, the mergeTPItem function will receive it as undefined, producing a full item without it.
cyaiox
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the upsert endpoint to return the full item after upserting it.